Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every example with your own module #844

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Every example with your own module #844

merged 4 commits into from
Feb 11, 2022

Conversation

robsonpeixoto
Copy link
Contributor

If you are using gopls with build.experimentalWorkspaceModule enabled the gopls will not start because the module name are being reused for different modules.

This PR will put all examples in your own module.

@robsonpeixoto robsonpeixoto changed the title Use a module for each example to avoid module name collision Every code example with your own module Feb 10, 2022
@robsonpeixoto robsonpeixoto changed the title Every code example with your own module Every example with your own module Feb 10, 2022
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@achille-roussel achille-roussel merged commit 7888926 into segmentio:main Feb 11, 2022
@robsonpeixoto robsonpeixoto deleted the gomod/review branch February 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants