Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Add Node 6 support. #143

Closed
wants to merge 4 commits into from
Closed

Add Node 6 support. #143

wants to merge 4 commits into from

Conversation

pin3da
Copy link

@pin3da pin3da commented Jun 24, 2016

It should solve #137 , #138 and #142

Note: I've modified some tests in order to use higher versions
of some packages.
@zeke
Copy link

zeke commented Jun 24, 2016

🤘

@jreut
Copy link

jreut commented Aug 28, 2016

Is there anything that needs doing before this PR can be accepted? I'm happy to help, as I'd like to use Myth under Node v6!

jreut pushed a commit to jreut/www that referenced this pull request Aug 28, 2016
@zeke
Copy link

zeke commented Aug 29, 2016

Is there anything that needs doing before this PR can be accepted?

Node 6 should be added to .travis.yml to ensure it's working.

If that passes I would happily merge this, but I'm not an owner of the npm package... one of the owners would need to be pinged to publish a new release.

@pin3da
Copy link
Author

pin3da commented Aug 31, 2016

@zeke Node 6 was already added in 3e493ed

@zeke
Copy link

zeke commented Jan 29, 2017

cc npm package owners: @dominicbarnes, @MoOx, @ianstormtaylor

I tried to come up with a one-liner to collect the github handles of the npm package owners, but I fell short. I got this far:

$ npm i -g npm-user-cli && npm owner ls myth | cut -d' ' -f1
dominicbarnes
ianstormtaylor
moox
segment-admin
segmentio

I thought I could pipe that to xargs npm-user, but it only executed the search for the first result, dominicbarnes. Any xargs / exec wizards in the house?

@MoOx
Copy link
Contributor

MoOx commented Jan 29, 2017

FYI, I am now the maintainer of a project that achieve the same goal called cssnext based on another engine (postcss). This projects support way more features and works in various versions of node ;)

@sbrl
Copy link

sbrl commented Jan 29, 2017

@MoOx Looks awesome! I think I'll use that instead then :-)

@sbrl
Copy link

sbrl commented Jan 30, 2017

And @zeke, I think you want the -I {} switch to xargs:

npm i -g npm-user-cli && npm owner ls myth | cut -d' ' -f1 | xargs -I {} npm-user {}

That limits it to 1 item per run of the command. Alternatively, you could do xargs -n 1 npm-owner instead I think.

jreut pushed a commit to jreut/www that referenced this pull request Jun 18, 2017
@pin3da pin3da closed this Jul 7, 2020
@sbrl
Copy link

sbrl commented Jul 9, 2020

Any particular reason for closing this @pin3da? Leaving a comment would be really helpful.

It's confusing when a PR gets closed for seemingly no reason with no explanation :-/

@pin3da
Copy link
Author

pin3da commented Jul 13, 2020

Sorry for closing it without any comment ):

The main reason is I was cleaning some open PRs, and this one did not have any activity in the last years. Also, I haven't been involved with nodejs in a while.

If there is still an interest/need on it, I can open it again and fix what is necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants