This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
move all merge code to merge.go #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
requested review from
lmarburger,
Pryz,
abraithwaite,
kevinburkesegment and
ngoldman-twilio
kevinburkesegment
approved these changes
Dec 14, 2022
achille-roussel
pushed a commit
that referenced
this pull request
Dec 14, 2022
* add parquet.RowBuilder * fixes for parquet row generation * add parquet.(*RowBuilder).Next * move all merge code to merge.go (#458) * move all merge code to merge.go * add example * add benchmark for parquet.(*RowBuilder).Add * initialize FIXED_LEN_BYTE_ARRAY columns to non-null zero-value * make it OK to call Next if the repetition level is zero
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply moves code between files so functions and types can be found in places where it is more intuitive (e.g. here, the Merge* functions are now all in merge.go).