Skip to content

Update RETL Query Length Limit #7077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

Lfdelossantos
Copy link
Contributor

@Lfdelossantos Lfdelossantos commented Sep 25, 2024

Hi, I am on the RETL team and we noticed that in our public docs we are using an erroneous value for the query length. For the query column in our MySQL DB we use MYSQL TEXT which has a character limit of 65,535. When a customer/user saves anything longer than that it auto truncates to that limit, which will lead to the query failing.

Confirmed that by writing a model query at 131,071 (right below our listed limit), and when I queried the DB it was truncated

mysql> select LENGTH(query) from reverse_etl_models where id = '5PuvDCsS6FdJXP2iJH3SiY';
+---------------+
| LENGTH(query) |
+---------------+
|         65535 |
+---------------+

Merge timing

Merge whenever it is approved please :)

Hi, I am on the RETL team and we noticed that in our public docs we are using an erroneous value for the query length. For the `query` column in our MySQL DB we use MYSQL `TEXT` which has a character limit of 65,535. When a customer/user saves anything longer than that it auto truncates to that limit, which will lead to the query failing.
@Lfdelossantos Lfdelossantos requested a review from a team as a code owner September 25, 2024 20:15
@forstisabella forstisabella added the fixed-content fix to content that has outdated or wrong information label Sep 25, 2024
@Lfdelossantos Lfdelossantos merged commit 145e084 into develop Sep 26, 2024
4 checks passed
@Lfdelossantos Lfdelossantos deleted the reverse-etl-limit-change branch September 26, 2024 03:56
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants