Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rokt Audience Set to Publicly Available #7214

Merged

Conversation

GoodmanBen
Copy link
Contributor

@GoodmanBen GoodmanBen commented Nov 11, 2024

Proposed changes

Set the Rokt Audiences Destination docs to public.

Merge timing

Related issues

N/A

@GoodmanBen GoodmanBen marked this pull request as ready for review November 12, 2024 18:33
@GoodmanBen GoodmanBen requested a review from a team as a code owner November 12, 2024 18:33
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@GoodmanBen GoodmanBen marked this pull request as draft November 12, 2024 19:24
@stayseesong
Copy link
Contributor

@GoodmanBen is this meant to be kept in draft mode?

@GoodmanBen
Copy link
Contributor Author

Hi @stayseesong thank you for checking. Yes the corresponding changes have been merged in for the linked PR, but not yet deployed due to a deploy freeze around Thanksgiving. It sounds like the changes will be deployed on the 3rd of December, at which point we will test in private beta and then release this to public beta. Will ping here once that is complete and we can move this PR out of draft mode.

@GoodmanBen GoodmanBen marked this pull request as ready for review December 9, 2024 22:42
@GoodmanBen
Copy link
Contributor Author

Hi @stayseesong, this has now been tested and validated in our private beta deployment and is ready for review.

…dex.md

Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
@tcgilbert
Copy link
Contributor

@stayseesong can we get this included in tomorrow's deployment?

@stayseesong stayseesong added the new-integration Added a new source or destination label Dec 12, 2024
@stayseesong stayseesong merged commit 6ab8b01 into segmentio:develop Dec 12, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants