-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Postscript Destination doc #7230
Conversation
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
I'm seeing closing quotes for all my quotes so I'm not sure what is going on here. Please provide more info. |
|
||
{% include content/plan-grid.md name="actions" %} | ||
|
||
[<Postscript>](https://postscript.io/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners){:target="_blank"} empowers ecommerce brands to drive incremental revenue through SMS marketing. With tools for subscriber growth, personalized messaging, and performance tracking, Postscript helps businesses engage their audience and boost conversions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @julesbravo - thanks for raising this PR.
The Segment Docs team will also review and will then push live.
I'll just add some preliminary feedback.
Could we add a short description to explain what this Integration does for the customer please?
i.e Enables Segment Engage Audiences to be sync to Postscript...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be worth explaining that identifiers which can be used to sync to Postscript are: email, phone only.
src/connections/destinations/catalog/actions-postscript/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-postscript/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-postscript/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Co-authored-by: pwseg <86626706+pwseg@users.noreply.github.com>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
@joe-ayoub-segment I have made the changes suggested. I'm still seeing the error on closing quotes, but when I ran it through a markdown validator it came back clean. |
Thanks @julesbravo . Hopefully @stayseesong from the Docs Team can get this figured out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julesbravo just one more thing to add. Otherwise, looks good to me.
I'm still seeing the error on closing quotes, but when I ran it through a markdown validator it came back clean.
the bot comments are new to me, not sure if this is an issue that would prevent this from being merged. @stayseesong is there anything left to change from the docs team POV?
src/connections/destinations/catalog/actions-postscript/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Added the ID |
How long should I expect this to take to review/merge? |
@julesbravo we deploy these on Tuesdays and Thursdays. I'll ping our docs team to make sure this gets included in tomorrows deploy. With this complete, once you are ready for the destination to go live in the catalog please submit it for final review from the dev portal here: https://app.segment.com/dev-portal/integrations/destination/actions-postscript/status |
@julesbravo Thanks for submitting this and working with the team to get it updated. Here's the live link in our docs: |
Proposed changes
Added Postscript destination docs
Merge timing
At your convenience
Related issues (optional)
None