subcmd/apply: Support fail-safe approach #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hhahn-tw Can you please review this one? :) |
|
@hhahn-tw @petedannemann Can you guys maybe take a look? |
|
@jkoelker Can you maybe review this PR? |
jkoelker
approved these changes
Mar 27, 2024
shimon-armis
force-pushed
the
shimon.support_fail_safe_approach_for_the_apply_cmd
branch
from
44deeff
to
1bf5d02
Compare
errors.Join() is only supported from go 1.20 (this repo is running v1.18). |
shimon-armis
force-pushed
the
shimon.support_fail_safe_approach_for_the_apply_cmd
branch
from
1bf5d02
to
430b161
Compare
Up until now, the `apply` command implemented a fail-fast strategy. This means that an attempt to configure a batch of topics (by passing a path to a folder contains a list of topics configurations files) will be terminated upon the first failure (w/o even trying to apply the configuration for the next-in-line topics). This commit introduces the fail-safe support: It allows the user to run the `apply` command in a fail-safe manner, which means that instead of failing upon the first failure, we'll simply continue to the next topic configuration, while aggregating all the errors along the way. Eventually, if there were any errors, all of them will be shown. Signed-off-by: shimon-armis <shimon.turjeman@armis.com>
shimon-armis
force-pushed
the
shimon.support_fail_safe_approach_for_the_apply_cmd
branch
from
430b161
to
661868a
Compare
|
@hhahn-tw Can you please merge this one? |
|
Thanks once more for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until now, the
applycommand implemented a fail-fast strategy. This means that an attempt to configure a batch of topics (by passing a path to a folder contains a list of topics configurations files) will be terminated upon the first failure (w/o even trying to apply the configuration for the next-in-line topics).This commit introduces the fail-safe support:
It allows the user to run the
applycommand in a fail-safe manner, which means that instead of failing upon the first failure, we'll simply continue to the next topic configuration, while aggregating all the errors along the way.Eventually, if there were any errors, all of them will be shown.