Support ERC/CW2981 in pointer contracts #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenlanders
approved these changes
May 15, 2024
jewei1997
reviewed
May 15, 2024
| bytes memory addr = JsonPrecompile.extractAsBytes(response, "address"); | ||
| uint256 amt = JsonPrecompile.extractAsUint256(response, "royalty_amount"); | ||
| if (addr.length == 0) { | ||
| return (address(0), amt); |
There was a problem hiding this comment.
should this be (address(0), 0)? I think we probably don't want to risk people burning funds on mistake.
There was a problem hiding this comment.
the cw2981 implementation makes look like it's a possible scenario for the payment address to be empty while the royalty is non-zero: https://github.com/CosmWasm/cw-nfts/blob/main/contracts/cw2981-royalties/src/lib.rs#L41-L45, so I'm not sure if we want to overwrite amt here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR adds ERC/CW2981 support, which involves the following query endpoints:
supportsInterfaceroyaltyInfoextension:royalty_infoextension:check_royaltiesNote that setting royalties needs to be done via
mintwhich is not currently supported by the pointers yet.Testing performed to validate your change
integration tests