Fixes local network in /scripts/run-node.py #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the order of operations to handle "local" mode properly, fixes 'nil validator set' error.
Several streamlining and UX improvements/fixes - Refactored script logic into manageable functions - Implemented logging using the logging module - Improved error handling throughout the script - Added prompts for environment and database backend selection - Ensured correct directory and file creation with appropriate permissions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
- Coverage 60.62% 60.53% -0.10%
==========================================
Files 370 370
Lines 27436 27436
==========================================
- Hits 16634 16608 -26
- Misses 9661 9689 +28
+ Partials 1141 1139 -2 |
philipsu522
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected order of operations to handle "local" mode properly, fixes 'nil validator set' error.
Corrected version handling, working directory and interrupting main script at proper time when "local" mode selected.