Make occ caused evm panics less noisy #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
- Coverage 60.74% 60.65% -0.10%
==========================================
Files 370 370
Lines 27433 27437 +4
==========================================
- Hits 16665 16641 -24
- Misses 9627 9654 +27
- Partials 1141 1142 +1
|
codchen
reviewed
Jun 11, 2024
x/evm/keeper/msg_server.go
Outdated
| @@ -62,10 +64,11 @@ func (server msgServer) EVMTransaction(goCtx context.Context, msg *types.MsgEVMT | |||
|
|
|||
| defer func() { | |||
| if pe := recover(); pe != nil { | |||
| // there is not supposed to be any panic | |||
| debug.PrintStack() | |||
There was a problem hiding this comment.
let's put this under the if below as well
codchen
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
If there is an evm panic due to occ conflict, don't log or increment metrics for this evm panic
Testing performed to validate your change
existing tests