Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dex actually #1816

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Remove dex actually #1816

merged 4 commits into from
Aug 20, 2024

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented Aug 9, 2024

Describe your changes and provide context

Testing performed to validate your change

@udpatil udpatil requested a review from yzang2019 August 9, 2024 21:49
@udpatil udpatil marked this pull request as ready for review August 10, 2024 01:31
@udpatil udpatil force-pushed the remove-dex-actually branch from ca5af22 to dda851c Compare August 10, 2024 01:31
@codecov Codecov
Copy link

codecov bot commented Aug 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (e8e4b3b) to head (3552695).
Report is 143 commits behind head on main.

Files Patch % Lines
app/app.go 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   61.64%   61.00%   -0.65%     
==========================================
  Files         365      257     -108     
  Lines       26178    22558    -3620     
==========================================
- Hits        16138    13761    -2377     
+ Misses       8967     7824    -1143     
+ Partials     1073      973     -100
Files Coverage Δ
aclmapping/bank/mappings.go 100.00% <ø> (ø)
app/ante.go 54.43% <ø> (+0.31%) ⬆️
app/antedecorators/gasless.go 78.99% <ø> (-9.74%) ⬇️
app/test_helpers.go 60.00% <ø> (+11.14%) ⬆️
app/upgrades.go 40.74% <ø> (ø)
app/app.go 66.55% <18.18%> (+1.63%) ⬆️

... and 176 files with indirect coverage changes

@udpatil udpatil force-pushed the remove-dex-actually branch from dda851c to ff25cb4 Compare August 20, 2024 17:46
@udpatil udpatil merged commit da9d59c into main Aug 20, 2024
48 of 49 checks passed
@udpatil udpatil deleted the remove-dex-actually branch August 20, 2024 20:21
yzang2019 added a commit that referenced this pull request Aug 27, 2024
@yzang2019
Merge branch 'main' into yzang/SEI-7926
b01e827 
* main:
  Increase timeout for evm hardhat tests (#1827)
  Fork event manager when creating EVM snapshots (#1831)
  Gas mispricing in cw vm patch (#1824)
  Remove dex actually (#1816)
  Bump seidb to fix receipt missing on restart issue (#1817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzang2019 yzang2019 yzang2019 approved these changes

Assignees
No one assigned
Labels
app-hash-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udpatil @yzang2019