Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occ] Add concurrency worker configuration #324

Merged
merged 13 commits into from
Oct 9, 2023
Merged

[occ] Add concurrency worker configuration #324

merged 13 commits into from
Oct 9, 2023

Conversation

stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented Oct 6, 2023 •
edited
Loading

Describe your changes and provide context

  • ConcurrencyWorkers represents the number of workers to use for concurrent transactions
  • since concurrrency-workers is a baseapp-level setting, implementations (like sei-chain) shouldn't have to pass it (but can)
  • it defaults to 10 if not set (via cli default value)
  • it defaults to 10 in app.toml only if that file is being created (and doesn't exist)
  • if explicitly set to zero on command line, it will override with the default (for safety)
  • cli takes precedence over the config file
  • no one has to do anything to get it to be 10 (no config changes no sei-chain changes required (aside from new cosmos version))

Testing performed to validate your change

  • Unit Tests for setting the value
  • Manually testing scenarios with sei-chain

@stevenlanders stevenlanders changed the title Add concurrency worker configuration [occ] Add concurrency worker configuration Oct 8, 2023
@codchen
Copy link
Collaborator

codchen commented Oct 9, 2023

Just curious how is 10 decided?

@stevenlanders
Copy link
Contributor Author

Just curious how is 10 decided?

@codchen We're going to start benchmarking a range of values, and thought it seemed like a good starting point for that.

udpatil
udpatil approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@udpatil udpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevenlanders stevenlanders merged commit c59bcca into occ-main Oct 9, 2023
14 checks passed
@stevenlanders stevenlanders deleted the add-concurrency-worker-configuration branch October 9, 2023 14:48
udpatil pushed a commit that referenced this pull request Oct 17, 2023
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
eef2149 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Oct 17, 2023
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
80502b7 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Oct 17, 2023
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
dac5f7b 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 2, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
b89c99d 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 8, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
500392e 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 18, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
b67a28e 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 18, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
8ff787e 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 25, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
ed4e262 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Jan 31, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
703b28a 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
codchen pushed a commit that referenced this pull request Feb 6, 2024
@stevenlanders @codchen
[occ] Add concurrency worker configuration (#324)
5deb388 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Feb 27, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
ab1b9b5 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
udpatil pushed a commit that referenced this pull request Mar 1, 2024
@stevenlanders @udpatil
[occ] Add concurrency worker configuration (#324)
c4c9052 
## Describe your changes and provide context
- `ConcurrencyWorkers` represents the number of workers to use for
concurrent transactions
- since concurrrency-workers is a baseapp-level setting, implementations
(like sei-chain) shouldn't have to pass it (but can)
- it defaults to 10 if not set (via cli default value)
- it defaults to 10 in app.toml only if that file is being created (and
doesn't exist)
- if explicitly set to zero on command line, it will override with the
default (for safety)
- cli takes precedence over the config file
- no one has to do anything to get it to be 10 (no config changes no
sei-chain changes required (aside from new cosmos version))

## Testing performed to validate your change
- Unit Tests for setting the value
- Manually testing scenarios with sei-chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codchen codchen codchen approved these changes

@udpatil udpatil udpatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenlanders @codchen @udpatil