Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occ] Implement iterator for mvkv #329

Merged
merged 4 commits into from
Oct 17, 2023
Merged

[occ] Implement iterator for mvkv #329

merged 4 commits into from
Oct 17, 2023

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Oct 12, 2023

Describe your changes and provide context

This implements Iterator and ReverseIterator for mvkv for the KVStore interface. The memiterator will be composed of versionindexedstore and multiversionstore, and will yield values in a cascading fashion firstly from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of reconstructing sorted keys each time.

Testing performed to validate your change

Unit test to verify basic functionality

stevenlanders
stevenlanders reviewed Oct 12, 2023
View reviewed changes
store/multiversion/memiterator.go

// if we have an estiamte, write to abort channel
if val.IsEstimate() {
mi.abortChannel <- scheduler.NewEstimateAbort(val.Index())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this keep processing here? (or maybe something upstream handles?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't because once we have an estimate, we can't know what the actual value will be that we need to read, so this abort would be expected to be handled within the task / scheduler level, and this tx index would need to wait for the "estimate" to be cleared

@udpatil udpatil marked this pull request as ready for review October 17, 2023 16:12
@udpatil udpatil merged commit 60c0ce5 into occ-main Oct 17, 2023
14 checks passed
@udpatil udpatil deleted the mvkv-iterator branch October 17, 2023 18:15
udpatil added a commit that referenced this pull request Oct 17, 2023
@udpatil
[occ] Implement iterator for mvkv (#329)
6aee7e2 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Oct 17, 2023
@udpatil
[occ] Implement iterator for mvkv (#329)
7041d2c 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Oct 17, 2023
@udpatil
[occ] Implement iterator for mvkv (#329)
dfb2260 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 2, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
f935dac 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 8, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
c637620 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 18, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
b54f533 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 18, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
f5bcfd1 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 25, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
5373952 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Jan 31, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
6406dd9 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
codchen pushed a commit that referenced this pull request Feb 6, 2024
@udpatil @codchen
[occ] Implement iterator for mvkv (#329)
61cfa6b 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Feb 27, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
d873dfb 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
udpatil added a commit that referenced this pull request Mar 1, 2024
@udpatil
[occ] Implement iterator for mvkv (#329)
3605f6b 
## Describe your changes and provide context
This implements Iterator and ReverseIterator for mvkv for the KVStore
interface. The memiterator will be composed of versionindexedstore and
multiversionstore, and will yield values in a cascading fashion firstly
from the writeset, and then second from the multiversion store.

This still needs optimization to persisted sorted keys instead of
reconstructing sorted keys each time.

## Testing performed to validate your change
Unit test to verify basic functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenlanders stevenlanders stevenlanders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udpatil @stevenlanders