[occ] Add struct field and helpers for estimate prefills #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## occ-main #341 +/- ##
============================================
- Coverage 56.09% 56.09% -0.01%
============================================
Files 627 627
Lines 52759 52773 +14
============================================
+ Hits 29597 29604 +7
- Misses 21060 21065 +5
- Partials 2102 2104 +2
|
stevenlanders
approved these changes
Oct 24, 2023
types/tx_batch.go
Outdated
|
|
||
| // DeliverTxEntry represents an individual transaction's request within a batch. | ||
| // This can be extended to include tx-level tracing or metadata | ||
| type DeliverTxEntry struct { | ||
| Request abci.RequestDeliverTx | ||
| Request abci.RequestDeliverTx | ||
| Metadata DeliverTxMetadata |
There was a problem hiding this comment.
2 cents: I'd probably would have just put the Writeset here, because Metadata normally means things like headers/trackers/tracers and not as much real-arguments to the function.
tasks/scheduler.go
Outdated
| @@ -57,6 +57,7 @@ func (dt *deliverTxTask) Increment() { | |||
|
|
|||
| // Scheduler processes tasks concurrently | |||
| type Scheduler interface { | |||
| PrefillEstimates(ctx sdk.Context, metadatas []sdk.DeliverTxMetadata) | |||
There was a problem hiding this comment.
2 cents: if this always must happen prior to ProcessAll, it may be worth just including the logic in ProcessAll to simplify the interaction.
…ield to be more descriptive of function
udpatil
added a commit
that referenced
this pull request
Jan 2, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 25, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Feb 27, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
udpatil
added a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch ## Testing performed to validate your change Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This adds in the ability to prefill estimates based on metadata passed along with deliverTxBatch
Testing performed to validate your change
Unit Test to verify that multiversion store initialization is now idempotent, and works properly regardless of whether estimate prefill is enabled