Fix map access panic #343
Merged
Fix map access panic #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
reviewed
Oct 30, 2023
| sortedItems := db.NewMemDB() | ||
|
|
||
| // get all writeset keys prior to index | ||
| keys := s.GetAllWritesetKeys() | ||
| keys := s.txWritesetKeys |
There was a problem hiding this comment.
this will acquire the lock for longer right? whereas none of the below logic actually invokes resources protected by the lock? does it make sense to do this way?
There was a problem hiding this comment.
meant to point to lines 246/247 where lock is acquired
There was a problem hiding this comment.
In Go, maps are always returned by reference, not by value. This means returning a reference via GetAllWritesetKeys doesn't give us a copy, and doesn't do anything to protect the map. The concurrent-access here is the keys[i] moment.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## occ-main #343 +/- ##
============================================
- Coverage 56.09% 56.09% -0.01%
============================================
Files 627 627
Lines 52773 52793 +20
============================================
+ Hits 29605 29615 +10
- Misses 21064 21074 +10
Partials 2104 2104
|
udpatil
approved these changes
Oct 30, 2023
udpatil
pushed a commit
that referenced
this pull request
Jan 2, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 25, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Feb 27, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
udpatil
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context - `CollectIteratorItems` needs to hold an RLock to avoid a concurrent access panic ## Testing performed to validate your change - Reproduced through a sei-chain-side test (concurrent instantiates)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
CollectIteratorItemsneeds to hold an RLock to avoid a concurrent access panicTesting performed to validate your change