Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change DeliverTx to take typed tx #360

Merged
merged 4 commits into from
Dec 4, 2023
Merged

change DeliverTx to take typed tx #360

merged 4 commits into from
Dec 4, 2023

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Nov 22, 2023 •
edited
Loading

Describe your changes and provide context

  • To avoid multiple deserialization, as well as adding cached values to sdk.Tx
  • Add new acl constants for evm subprefixes
  • Add a new bank send method that doesn't automatically create accounts

Testing performed to validate your change

unit tests & local sei integration

@codchen codchen force-pushed the pass-sdk-tx-directly branch 2 times, most recently from 1bbf4bb to b43df68 Compare November 27, 2023 12:16
@stevenlanders
Copy link
Contributor

(@udpatil note this probably will affect OCC's deliverTxBatch interface when we eventually merge these together)

jewei1997
jewei1997 reviewed Nov 28, 2023
View reviewed changes
baseapp/baseapp.go
@@ -942,7 +939,7 @@ func (app *BaseApp) runTx(ctx sdk.Context, mode runTxMode, txBytes []byte) (gInf
// NOTE: Alternatively, we could require that AnteHandler ensures that
// writes do not happen if aborted/failed. This may have some
// performance benefits, but it'll be more difficult to get right.
anteCtx, msCache = app.cacheTxContext(ctx, txBytes)
anteCtx, msCache = app.cacheTxContext(ctx, checksum)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we use the SHA256 over the txBytes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jewei1997 in cacheTxContext, txBytes is only used to calculate its sha256, so we just pass in the calculated sha256 directly

@codchen codchen merged commit ef4fe84 into evm-temp Dec 4, 2023
14 checks passed
@codchen codchen deleted the pass-sdk-tx-directly branch December 4, 2023 13:20
codchen added a commit that referenced this pull request Jan 5, 2024
@codchen
change DeliverTx to take typed tx (#360)
a885770 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
codchen added a commit that referenced this pull request Jan 11, 2024
@codchen
change DeliverTx to take typed tx (#360)
272da15 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
stevenlanders pushed a commit that referenced this pull request Jan 30, 2024
@codchen @stevenlanders
change DeliverTx to take typed tx (#360)
31f0f7b 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Jan 31, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
73699cf 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
stevenlanders pushed a commit that referenced this pull request Feb 6, 2024
@codchen @stevenlanders
change DeliverTx to take typed tx (#360)
d8b6659 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
stevenlanders pushed a commit that referenced this pull request Feb 8, 2024
@codchen @stevenlanders
change DeliverTx to take typed tx (#360)
c668e2a 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Feb 28, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
569d6e4 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Feb 28, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
066dc61 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 1, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
08ac747 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 4, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
496ea0f 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 11, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
575036b 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 14, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
cf98904 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 26, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
f91de63 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 26, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
6b93029 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Mar 27, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
a7649f7 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Apr 16, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
47ca30c 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Apr 19, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
167176c 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
udpatil pushed a commit that referenced this pull request Apr 19, 2024
@codchen @udpatil
change DeliverTx to take typed tx (#360)
cd63822 
- To avoid multiple deserialization, as well as adding cached values to
sdk.Tx
- Add new acl constants for evm subprefixes
- Add a new bank send method that doesn't automatically create accounts
unit tests & local sei integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewei1997 jewei1997 jewei1997 left review comments

@udpatil udpatil Awaiting requested review from udpatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codchen @stevenlanders @jewei1997