Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[occ] Add optimizations for multiversion and mvkv #361

Merged
merged 16 commits into from
Nov 27, 2023

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Nov 22, 2023

Describe your changes and provide context

Add optimizations to reduce mutex lock contention and refactor with sync Maps. This also removes telemetry that was added liberally, and we can later add in telemetry more mindfully and feature flagged.

Testing performed to validate your change

loadtest chain testing

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #361 (226a3d4) into occ-main (6260732) will decrease coverage by 0.10%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           occ-main     #361      +/-   ##
============================================
- Coverage     56.18%   56.09%   -0.10%     
============================================
  Files           627      627              
  Lines         52926    52865      -61     
============================================
- Hits          29738    29655      -83     
- Misses        21082    21102      +20     
- Partials       2106     2108       +2     
Files Coverage Δ
baseapp/baseapp.go 72.05% <100.00%> (ø)
store/cache/cache.go 78.57% <100.00%> (ø)
store/multiversion/mvkv.go 97.24% <100.00%> (+0.09%) ⬆️
tasks/scheduler.go 85.56% <100.00%> (+0.10%) ⬆️
store/types/cache.go 48.68% <66.66%> (-14.48%) ⬇️
store/cachekv/store.go 74.60% <95.12%> (+1.45%) ⬆️
store/multiversion/store.go 90.81% <78.57%> (-4.39%) ⬇️

... and 2 files with indirect coverage changes

@udpatil udpatil merged commit c660786 into occ-main Nov 27, 2023
15 checks passed
@udpatil udpatil deleted the occ-optimized-cleanup-2 branch November 27, 2023 14:56
udpatil added a commit that referenced this pull request Jan 2, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 8, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 8, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 18, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 18, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 25, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Jan 31, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
codchen pushed a commit that referenced this pull request Feb 6, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Feb 27, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
udpatil added a commit that referenced this pull request Mar 1, 2024
Add optimizations to reduce mutex lock contention and refactor with sync
Maps. This also removes telemetry that was added liberally, and we can
later add in telemetry more mindfully and feature flagged.

loadtest chain testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants