[SeiDB] Fix SS apply changeset version off by 1 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 54.81% 54.80% -0.01%
==========================================
Files 622 622
Lines 52205 52213 +8
==========================================
Hits 28615 28615
- Misses 21506 21514 +8
Partials 2084 2084
|
philipsu522
approved these changes
Feb 7, 2024
udpatil
pushed a commit
that referenced
this pull request
Feb 9, 2024
## Describe your changes and provide context Problem: When apply changeset to SS store, currently we are using the lastCommitInfo version, which is the previous block height. This means the version is off by 1. The correct way is to use the current block height for the changeset version ## Testing performed to validate your change Will add integration test for this test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
When apply changeset to SS store, currently we are using the lastCommitInfo version, which is the previous block height. This means the version is off by 1. The correct way is to use the current block height for the changeset version
Testing performed to validate your change
Will add integration test for this test case