Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify max incarnation fallback #460

Merged
merged 31 commits into from
Mar 14, 2024
Merged

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Mar 13, 2024

Describe your changes and provide context

Testing performed to validate your change

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (e9376f4) to head (7801343).
Report is 68 commits behind head on seiv2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2     #460      +/-   ##
==========================================
+ Coverage   55.34%   55.36%   +0.01%     
==========================================
  Files         629      629              
  Lines       53825    53878      +53     
==========================================
+ Hits        29791    29827      +36     
- Misses      21905    21917      +12     
- Partials     2129     2134       +5     
Files Coverage Δ
store/multiversion/store.go 90.96% <100.00%> (+0.15%) ⬆️
tasks/scheduler.go 88.88% <76.66%> (-3.05%) ⬇️

... and 43 files with indirect coverage changes

@udpatil udpatil marked this pull request as ready for review March 13, 2024 22:20
@udpatil udpatil merged commit 7f668bd into seiv2 Mar 14, 2024
13 checks passed
@udpatil udpatil deleted the modify-max-incarnation-fallback branch March 14, 2024 14:05
udpatil added a commit that referenced this pull request Mar 14, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Mar 26, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Mar 26, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Mar 27, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Apr 16, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Apr 19, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
udpatil added a commit that referenced this pull request Apr 19, 2024
---------

Co-authored-by: Steven Landers <steven@seinetwork.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants