Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive Node Migration: Expose Get State Store + Query Iavl Before Migration Height #541

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Archive Node Migration: Expose Get State Store + Query Iavl Before Migration Height #541

wants to merge 6 commits into from

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Sep 23, 2024 •
edited
Loading

Describe your changes and provide context

  • Exposes GetStateStore from rootmulti
  • For historical queries, if before migration height, points to iavl

Testing performed to validate your change

  • Verified and tested on node

@Kbhat1 Kbhat1 mentioned this pull request Sep 23, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.17647% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (4e7d467) to head (208d226).

Files with missing lines Patch % Lines
baseapp/abci.go 51.85% 9 Missing and 4 partials ⚠️
baseapp/options.go 0.00% 4 Missing ⚠️
storev2/rootmulti/store.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   54.90%   54.89%   -0.01%     
==========================================
  Files         631      631              
  Lines       54920    54946      +26     
==========================================
+ Hits        30152    30163      +11     
- Misses      22614    22626      +12     
- Partials     2154     2157       +3
Files with missing lines Coverage Δ
baseapp/baseapp.go 66.34% <ø> (ø)
storev2/rootmulti/store.go 2.60% <0.00%> (-0.01%) ⬇️
baseapp/options.go 46.78% <0.00%> (-1.13%) ⬇️
baseapp/abci.go 52.45% <51.85%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

yzang2019 and others added 2 commits September 24, 2024 23:13
@yzang2019
Add QMS for IAVL migration query multistore (#542)
e618491 
## Describe your changes and provide context
This PR add an extra QMS used for serving online migration query
fallback. When the request height is lower than the migration height, we
will fall back to read from IAVL store, otherwise, it will use the
default CMS

## Testing performed to validate your change
@Kbhat1
Remove panic
ca29513
@Kbhat1 Kbhat1 changed the title Expose Get State Store Archive Node Migration: Expose Get State Store + Query Iavl Before Migration Height Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzang2019 yzang2019 Awaiting requested review from yzang2019

@udpatil udpatil Awaiting requested review from udpatil

@codchen codchen Awaiting requested review from codchen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kbhat1 @yzang2019