Reduce noisy tendermint logs #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Oct 11, 2023
| @@ -2003,7 +2003,7 @@ func (cs *State) enterCommit(ctx context.Context, height int64, commitRound int3 | |||
| logger := cs.logger.With("height", height, "commit_round", commitRound) | |||
|
|
|||
| if cs.roundState.Height() != height || cstypes.RoundStepCommit <= cs.roundState.Step() { | |||
| logger.Info( | |||
| logger.Debug( | |||
There was a problem hiding this comment.
shoudl we do the same with some of the other "entering..." logs?
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1602
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1616
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1807
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1822
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1848
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1858
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1968
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L1984
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L2006
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L2006
- https://github.com/sei-protocol/sei-tendermint/blob/main/internal/consensus/state.go#L2103
There was a problem hiding this comment.
Fixed, check again?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 58.98% 58.99% +0.01%
==========================================
Files 281 281
Lines 38858 38858
==========================================
+ Hits 22922 22926 +4
- Misses 14145 14147 +2
+ Partials 1791 1785 -6
|
codchen
approved these changes
Oct 12, 2023
Yeah, there'll still be logs around commit info such as: |
philipsu522
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This change will help to reduce the noisy logs such as
Testing performed to validate your change