Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Rebase main #199

Merged
merged 16 commits into from
Jan 30, 2024
Merged

[EVM] Rebase main #199

merged 16 commits into from
Jan 30, 2024

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • rebase main

Testing performed to validate your change

  • unit tests

yzang2019 and others added 16 commits January 12, 2024 08:50
* Standardize lag status response format

* Fix flaky unit test
* Perf: Increase buffer size for pubsub server to boost performance (#167)

* Increase buffer size for pubsub server

* Add more timeout for test failure

* Add more timeout

* Fix test split scripts

* Fix test split

* Fix unit test

* Unit test

* Unit test

* [P2P] Optimize block pool requester retry and peer pick up logic (#170)

* P2P Improvements: Fix block sync reactor and block pool retry logic

* Revert "Add event data to result event (#165)" (#176)

This reverts commit 72bb29c.

* Fix block sync auto restart not working as expected (#175)

* Fix edge case for blocksync (#178)

* fix evm pending nonce

* fix test

* deflake a test

* de-flake test

* Revert "merge main"

This reverts commit 58b9424, reversing
changes made to 02d1478.

* consider keep-in-cache logic when removing from cache

* undo test tweaks

---------

Co-authored-by: Yiming Zang <50607998+yzang2019@users.noreply.github.com>
Co-authored-by: Jeremy Wei <jeremy.t.wei@gmail.com>
* Add metrics for mempool pending transaction size

* Add expired tx count metrics
* add mempool prioritization with evm nonce

* fix priority stability

* index fixes

* replace with binary search insert

* impl binary search
* debug duplicate evm tx

* add more logs

* add some \ns

* more logs

* fix swap check

* add-lockable-reap-by-gas

* add invariant checks

* fix invariant parenthesis

* fix log

* remove invalid invariant

* fix nonce ordering pain

* handle ordering of insert

* fix remove

* cleanup

* fix imports

* cleanup

* avoid getTransactionByHash(hash) panic due to index

* use Key() to compare instead of pointer
* prevent duplicates in mempool

* use timestamp in priority queue
* add logging for expired txs

* cleanup
* remove heapIndex to avoid nil scenario

* avoid returning nil in loop (mimic Peek)
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (da59b8d) 57.94% compared to head (5b7c3b0) 58.20%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   57.94%   58.20%   +0.25%     
==========================================
  Files         249      249              
  Lines       33915    34185     +270     
==========================================
+ Hits        19651    19896     +245     
- Misses      12692    12715      +23     
- Partials     1572     1574       +2     
Files Coverage Δ
abci/types/types.go 18.18% <ø> (ø)
rpc/client/mock/abci.go 59.75% <100.00%> (ø)
internal/proxy/client.go 21.66% <0.00%> (ø)
abci/example/kvstore/kvstore.go 53.79% <0.00%> (ø)
abci/types/application.go 0.00% <0.00%> (ø)
abci/types/messages.go 4.76% <0.00%> (ø)
internal/rpc/core/mempool.go 0.00% <0.00%> (ø)
internal/mempool/priority_queue.go 94.78% <92.02%> (-4.11%) ⬇️
internal/mempool/metrics.gen.go 16.17% <14.28%> (-0.50%) ⬇️
internal/mempool/mempool.go 68.75% <77.06%> (-1.37%) ⬇️
... and 1 more

... and 18 files with indirect coverage changes

@stevenlanders stevenlanders changed the base branch from main to evm-temp January 30, 2024 14:50
@stevenlanders stevenlanders merged commit 4f67f2a into evm-temp Jan 30, 2024
24 checks passed
@stevenlanders stevenlanders deleted the rebase-main branch January 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants