-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux cooked capture v2 #1138
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1138 +/- ##
==========================================
- Coverage 82.18% 82.10% -0.08%
==========================================
Files 154 156 +2
Lines 19941 20093 +152
Branches 7531 7575 +44
==========================================
+ Hits 16388 16497 +109
- Misses 3038 3074 +36
- Partials 515 522 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jiangjiongyu did you see my comments? do you have time to address them? |
Is this patch needed to support linux cooked capture v2 in live capture into file? I tried to understand why tcpdump creates pcap files with linux cooked capture v2 and pcap++ don't. |
@bitFiedler this PR will support SLLv2 which is currently not a supported protocol. This means that packets in a pcap file with this link type won't be parsed correctly and will contain only one layer which is the generic |
@jiangjiongyu did you see my recent comments? Do you think you'll have time to fix the PR so we can merge it? |
@jiangjiongyu please fix the tests as they are failing: https://github.com/seladb/PcapPlusPlus/actions/runs/5510656390/jobs/10156347599?pr=1138 |
I already check the test file path.Why those test can't pass? |
@jiangjiongyu you fixed the previous issue, but now there are other problems that need fixing:
|
- Instead, add a test to read and write SLL2 pcap files
No description provided.