Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodegroup taints support #50

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Nodegroup taints support #50

merged 5 commits into from
Sep 1, 2020

Conversation

dstdfx
Copy link
Contributor

@dstdfx dstdfx commented Aug 31, 2020

For #49

@dstdfx
Nodegroup taints support
746360a 
Add Taint struct.

Add []nodegroup.Taint into nodegroup.View and nodegroup.CreateOpts.

Update tests.
@dstdfx
Fix fixtures format
55a78c6
@dstdfx dstdfx mentioned this pull request Aug 31, 2020
Closed
ozerovandrei
ozerovandrei suggested changes Aug 31, 2020
View reviewed changes
pkg/v1/cluster/testing/fixtures.go Outdated Show resolved Hide resolved
kolsean
kolsean reviewed Aug 31, 2020
View reviewed changes
pkg/v1/cluster/doc.go Outdated Show resolved Hide resolved
kolsean
kolsean requested changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix doc

kolsean
kolsean requested changes Aug 31, 2020
View reviewed changes
pkg/v1/cluster/doc.go Outdated Show resolved Hide resolved
ozerovandrei
ozerovandrei approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kolsean
kolsean approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dstdfx dstdfx merged commit ce21ef3 into selectel:master Sep 1, 2020
@dstdfx dstdfx deleted the nodegroup-taints branch September 1, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolsean kolsean kolsean approved these changes

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstdfx @ozerovandrei @kolsean