Add datastore type dependent DBaaS resources #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkder3k
reviewed
Aug 31, 2022
Gogen120
force-pushed
the
feature/added-datastore-type-dependent-dbaas-resources
branch
from
7d10468 to
3730c4e
Compare
kolsean
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Some acceptance tests were failed, e.g:
=== RUN TestAccDBaaSFlavorsV1Basic
data_source_selectel_dbaas_flavor_v1_test.go:23: Step 1/2 error: Check failed: Check 8/8 error: data.selectel_dbaas_flavor_v1.flavor_tf_acc_test_1: Attribute 'flavors.0.datastore_type_ids.#' expected "9", got "14"
--- FAIL: TestAccDBaaSFlavorsV1Basic (105.17s)
Please check.
added 3 commits
October 18, 2022 11:35
- Add datastore, databases, extension resources for specific datastore type: selectel_dbaas_postgresql_datastore_v1, selectel_dbaas_mysql_datastore_v1, selectel_dbaas_redis_datastore_v1, selectel_dbaas_postgresql_database_v1, selectel_dbaas_mysql_database_v1, selectel_dbaas_postgresql_extension_v1 - Mark old datastore, databases, extension that were available for all types as deprecated
- Add nl-1 endpoint to the regions - Use dbaas-go v0.6.0 with config parser
Fixed |
kolsean
requested changes
Nov 1, 2022
There was a problem hiding this comment.
here we go again
=== RUN TestAccDBaaSMySQLDatastoreV1Basic
resource_selectel_dbaas_mysql_datastore_v1_test.go:27: Step 4/5 error: Error running apply: exit status 1
Error: error updating datastore '1f1e8b7e-be3f-4517-9dea-902eeedfe68e': Bad Request: Validation failure: datastore cannot be resized. Code: 400
on terraform_plugin_test.tf line 21, in resource "selectel_dbaas_mysql_datastore_v1" "datastore_tf_acc_test_1":
21: resource "selectel_dbaas_mysql_datastore_v1" "datastore_tf_acc_test_1" {
--- FAIL: TestAccDBaaSMySQLDatastoreV1Basic (569.79s)
382b9f5 to
c5e44fe
Compare
Gogen120
deleted the
feature/added-datastore-type-dependent-dbaas-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add datastore, databases, extension resources for specific datastore types:
selectel_dbaas_postgresql_datastore_v1,selectel_dbaas_mysql_datastore_v1,selectel_dbaas_redis_datastore_v1,selectel_dbaas_postgresql_database_v1,selectel_dbaas_mysql_database_v1,selectel_dbaas_postgresql_extension_v1Mark old datastore, databases, extension that were available for all types as deprecated