-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DBaaS resources #251
Merged
kolsean
merged 6 commits into
selectel:master
from
Gogen120:dbaas_resources_refactoring
May 15, 2024
Merged
Refactor DBaaS resources #251
kolsean
merged 6 commits into
selectel:master
from
Gogen120:dbaas_resources_refactoring
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gogen120
force-pushed
the
dbaas_resources_refactoring
branch
from
February 27, 2024 14:37
8fd5ce6
to
6599cb9
Compare
TruePack
force-pushed
the
dbaas_resources_refactoring
branch
from
February 28, 2024 07:17
6599cb9
to
5c71fda
Compare
TruePack
suggested changes
Feb 28, 2024
selectel/data_source_selectel_dbaas_configuration_parameter_v1.go
Outdated
Show resolved
Hide resolved
Gogen120
force-pushed
the
dbaas_resources_refactoring
branch
2 times, most recently
from
February 28, 2024 17:22
2a4ec5c
to
ed96b1e
Compare
Gogen120
force-pushed
the
dbaas_resources_refactoring
branch
2 times, most recently
from
April 18, 2024 08:43
71d723f
to
f28dd56
Compare
- Added new package waiters with wait function for DBaaS resources - Remove redundant usage of selMutexKV - Remove usage of flag ForceNew with False value as it is a default value - Replace an old MinTimeout value with calculated value on production - Add fl_size and invalid_values fields for Flavor and ConfigurationParameters data sources, respectively
- Add base schemas for datastore and database resources - Add required fields for each datastore type in corresponding schema instead of deleting unused fields - Use Sensitive: true for password fields
Gogen120
force-pushed
the
dbaas_resources_refactoring
branch
from
April 23, 2024 13:45
f28dd56
to
de366eb
Compare
TawR1024
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kolsean
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema_selectel_dbaas_*