Add selectel_dbaas_firewall_v1 resource #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gogen120
force-pushed
the
add_dbaas_firewall_resource
branch
from
c13bf23
to
19fa651
Compare
- Make firewall field for datastore resources deprecated. Because, we cannot change firewall state during creation of the datastore only after - Add a new selectel_dbaas_firewall_v1 resource to manage datastore's firewall
Gogen120
force-pushed
the
add_dbaas_firewall_resource
branch
from
19fa651
to
8f0654e
Compare
Vasilek15
approved these changes
Aug 7, 2024
TawR1024
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make firewall field for datastore resources deprecated. Because, we cannot change firewall state during creation of the datastore, only after. For example, if we create a datastore with defined firewall, then it will be applied only after the second run of
terraform apply. That's an unexpected behavior. It can be fixed with introducing a separateselectel_dbaas_firewall_v1resource to manage datastore's firewall, that attached to datastore withdatastore_idfieldRelations
Closes #277