Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for backup_retention_days field #297

Conversation

Gogen120
Copy link
Contributor

Description

Set 7 as a default number of backup retention days for dbaas resources. It fixes a problem when after the second apply terraform tries to update backup_retention_days value to null

Relations

Closes #296

Icerzack
Icerzack previously approved these changes Sep 5, 2024
Copy link
Member

@Icerzack Icerzack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А стоит ли также обновить соответствующие .md файлы с документацией, ведь теперь backup_retention_days находится в конкрентных datastore?

Set default number of backup retention days as 7 for dbaas resources
@Gogen120
Copy link
Contributor Author

Gogen120 commented Sep 6, 2024

А стоит ли также обновить соответствующие .md файлы с документацией, ведь теперь backup_retention_days находится в конкрентных datastore?

Да, ты прав. Обновил их

@sel-bukharov sel-bukharov merged commit 505039f into selectel:master Sep 9, 2024
8 checks passed
@Gogen120 Gogen120 deleted the fix/add-default-value-for-backup-retention-days branch September 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBaaS PosgresSQL requires backup_retention_days on seconds apply
3 participants