Simplify hash functions in servers and quotas

Use simple fmt.Sprintf instead of working with buffers in the "hashQuotas" and "hashServers" functions.
selectel · Nov 7, 2018 · ffaa12f · ffaa12f
1 parent a73aaf0
commit ffaa12f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/selvpc/resource_selvpc_resell_project_v2.go b/selvpc/resource_selvpc_resell_project_v2.go
@@ -432,10 +432,8 @@ func resourceQuotasHashSetFunc() schema.SchemaSetFunc {
 
 // hashQuotas is a hash function to use with the "quotas" and "all_quotas" sets.
 func hashQuotas(v interface{}) int {
-	var buf bytes.Buffer
 	m := v.(map[string]interface{})
-	buf.WriteString(fmt.Sprintf("%s-", m["resource_name"].(string)))
-	return hashcode.String(buf.String())
+	return hashcode.String(fmt.Sprintf("%s-", m["resource_name"].(string)))
 }
 
 // hashResourceQuotas is a hash function to use with the "resource_quotas" set.

diff --git a/selvpc/servers.go b/selvpc/servers.go
@@ -1,7 +1,6 @@
 package selvpc
 
 import (
-	"bytes"
 	"fmt"
 
 	"github.com/hashicorp/terraform/helper/hashcode"
@@ -28,8 +27,6 @@ func serversMapsFromStructs(serverStructs []servers.Server) []map[string]interfa
 
 // hashServers is a hash function to use with the "servers" set.
 func hashServers(v interface{}) int {
-	var buf bytes.Buffer
 	m := v.(map[string]interface{})
-	buf.WriteString(fmt.Sprintf("%s-", m["id"].(string)))
-	return hashcode.String(buf.String())
+	return hashcode.String(fmt.Sprintf("%s-", m["id"].(string)))
 }