Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectified #1164 issue, considered previously fixed #1575

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

anandphulwani
Copy link
Contributor

Rectified #1164 issue considered previously fixed, done with the pull
#1353 and
pushed commit
michael-maltsev@f6e9faa

This has to be if (self.isBlurring) { and not if (!self.isBlurring) {
Reasons

  • The problem still exists from 0.12.3 - 0.12.6 version.
  • Have changed it to if (self.isBlurring) { and control behaves perfectly in my initial tests.
  • My two cents here, when we are replacing ignoreFocus with isBlurring and have initialized both flags with same boolean values everywhere in the code, shouldn't the if statement should also be similar?

Rectified selectize#1164 issue considered previously fixed, done with the pull
selectize#1353 and
pushed commit
michael-maltsev@f6e9faa
@anandphulwani
Copy link
Contributor Author

As mentioned here, the check is also failing in the earlier pull request.
#1353 (comment)

@risadams risadams merged commit 7b05203 into selectize:master Jan 17, 2021
@anandphulwani anandphulwani deleted the recitfy-isBlurring-flag branch February 21, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants