Skip to content

Commit

Permalink
Merge pull request #2038 from seleniumbase/driver-manager-updates
Browse files Browse the repository at this point in the history
Make improvements to the Driver Manager
  • Loading branch information
mdmintz authored Aug 28, 2023
2 parents 101bd16 + 099d8f7 commit ea02531
Show file tree
Hide file tree
Showing 15 changed files with 560 additions and 265 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1332,13 +1332,14 @@ pytest --reruns=1 --reruns-delay=1
<span><a href="https://www.youtube.com/playlist?list=PLp9uKicxkBc5UIlGi2BuE3aWC7JyXpD3m"><img src="https://seleniumbase.github.io/cdn/img/youtube.png" title="SeleniumBase Playlist on YouTube" alt="SeleniumBase Playlist on YouTube" width="68" /></a></span>
<span><a href="https://github.com/seleniumbase/SeleniumBase"><img src="https://seleniumbase.github.io/img/social/share_github.svg" title="SeleniumBase on GitHub" alt="SeleniumBase on GitHub" width="62" /></a></span>
<span><a href="https://www.facebook.com/SeleniumBase"><img src="https://seleniumbase.io/img/social/share_facebook.svg" title="SeleniumBase on Facebook" alt="SeleniumBase on Facebook" width="64" /></a></span>
<span><a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://seleniumbase.github.io/img/social/share_gitter.svg" title="SeleniumBase on Gitter" alt="SeleniumBase on Gitter" width="52" /></a></span>
<span><a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://seleniumbase.github.io/img/social/share_gitter.svg" title="SeleniumBase on Gitter" alt="SeleniumBase on Gitter" width="50" /></a></span>
</div></p>
<p><div><a href="https://github.com/mdmintz">https://github.com/mdmintz</a></div></p>
<p><div><b><a href="https://github.com/mdmintz">https://github.com/mdmintz</a></b></div></p>
<div><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.github.io/cdn/img/fancy_logo_14.png" title="SeleniumBase" width="220" /></a></div> <div><a href="https://github.com/seleniumbase/SeleniumBase/blob/master/LICENSE"><img src="https://img.shields.io/badge/license-MIT-22BBCC.svg" title="SeleniumBase" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://img.shields.io/gitter/room/seleniumbase/SeleniumBase.svg" alt="Gitter chat"/></a></div> <div><a href="https://github.com/seleniumbase/SeleniumBase"><img src="https://img.shields.io/badge/tested%20with-SeleniumBase-04C38E.svg" alt="Tested with SeleniumBase" /></a></div> <div><a href="https://seleniumbase.io"><img src="https://img.shields.io/badge/docs-seleniumbase.io-11BBAA.svg" alt="SeleniumBase Docs" /></a></div>
<div><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.github.io/cdn/img/fancy_logo_14.png" title="SeleniumBase" width="240" /></a></div> <div><a href="https://seleniumbase.io"><img src="https://img.shields.io/badge/docs-seleniumbase.io-11BBAA.svg" alt="SeleniumBase Docs" /></a></div> <div><a href="https://github.com/seleniumbase/SeleniumBase"><img src="https://img.shields.io/badge/tested%20with-SeleniumBase-04C38E.svg" alt="Tested with SeleniumBase" /></a></div> <div><a href="https://github.com/seleniumbase/SeleniumBase/blob/master/LICENSE"><img src="https://img.shields.io/badge/license-MIT-22BBCC.svg" title="SeleniumBase" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://img.shields.io/gitter/room/seleniumbase/SeleniumBase.svg" alt="Gitter chat"/></a></div>
<div><a href="https://pepy.tech/project/seleniumbase" target="_blank"><img src="https://static.pepy.tech/badge/seleniumbase" alt="SeleniumBase PyPI downloads" /></a></div>
<img src="https://visitor-badge.laobi.icu/badge?page_id=seleniumbase" alt="visitor badge"/>
<div><a href="https://github.com/seleniumbase/SeleniumBase/stargazers"><img src="https://img.shields.io/github/stars/seleniumbase/seleniumbase.svg?color=19A57B" title="Stargazers" /></a></div>
--------
Expand Down
6 changes: 6 additions & 0 deletions examples/custom_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@
HEADLESS_START_WIDTH = 1440
HEADLESS_START_HEIGHT = 1880

# If True, hides messages related to downloading drivers.
# If False, you'll see details about downloading drivers.
# (This only affects driver downloads coming from tests.)
# (Eg. Using "sbase get chromedriver" won't hide output.)
HIDE_DRIVER_DOWNLOADS = False

# Changing the default behavior of MasterQA Mode.
MASTERQA_DEFAULT_VALIDATION_MESSAGE = "Does the page look good?"
MASTERQA_WAIT_TIME_BEFORE_VERIFY = 0.5
Expand Down
6 changes: 6 additions & 0 deletions help_docs/webdriver_installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ If the necessary driver is not found in this location while running tests, Selen
```bash
sbase get chromedriver 114
sbase get chromedriver 114.0.5735.90
sbase get chromedriver stable
sbase get chromedriver beta
sbase get chromedriver dev
sbase get chromedriver canary
sbase get chromedriver previous # One major version before the stable version
sbase get chromedriver mlatest # Milestone latest version for detected browser
sbase get edgedriver 115.0.1901.183
```

Expand Down
2 changes: 1 addition & 1 deletion mkdocs_build/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ paginate==0.5.6
pyquery==2.0.0
readtime==3.0.0
mkdocs==1.5.2
mkdocs-material==9.2.3
mkdocs-material==9.2.5
mkdocs-exclude-search==0.6.5
mkdocs-simple-hooks==0.1.5
mkdocs-material-extensions==1.1.1
6 changes: 4 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ attrs==22.1.0;python_version<"3.7"
attrs>=23.1.0;python_version>="3.7"
certifi>=2023.7.22
filelock>=3.4.1;python_version<"3.7"
filelock>=3.12.2;python_version>="3.7"
filelock>=3.12.2;python_version>="3.7" and python_version<"3.8"
filelock>=3.12.3;python_version>="3.8"
platformdirs>=2.4.0;python_version<"3.7"
platformdirs>=3.10.0;python_version>="3.7"
parse>=1.19.1
Expand Down Expand Up @@ -47,7 +48,8 @@ execnet==2.0.2;python_version>="3.7"
iniconfig==1.1.1;python_version<"3.7"
iniconfig==2.0.0;python_version>="3.7"
pluggy==1.0.0;python_version<"3.7"
pluggy==1.2.0;python_version>="3.7"
pluggy==1.2.0;python_version>="3.7" and python_version<"3.8"
pluggy==1.3.0;python_version>="3.8"
py==1.11.0
pytest==7.0.1;python_version<"3.7"
pytest==7.4.0;python_version>="3.7"
Expand Down
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.17.11"
__version__ = "4.17.12"
6 changes: 6 additions & 0 deletions seleniumbase/config/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@
HEADLESS_START_WIDTH = 1440
HEADLESS_START_HEIGHT = 1880

# If True, hides messages related to downloading drivers.
# If False, you'll see details about downloading drivers.
# (This only affects driver downloads coming from tests.)
# (If calling "sbase get chromedriver", then won't hide.)
HIDE_DRIVER_DOWNLOADS = False

# #####>>>>>----- MasterQA SETTINGS -----<<<<<#####
# ##### (Used when importing MasterQA as the parent class)

Expand Down
2 changes: 2 additions & 0 deletions seleniumbase/console_scripts/ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ sbase get geckodriver
sbase get edgedriver
sbase get chromedriver 114
sbase get chromedriver 114.0.5735.90
sbase get chromedriver stable
sbase get chromedriver beta
sbase get chromedriver -p
```

Expand Down
4 changes: 4 additions & 0 deletions seleniumbase/console_scripts/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import colorama
import sys
import time
from seleniumbase.config import settings
from seleniumbase.fixtures import constants

colorama.init(autoreset=True)
Expand Down Expand Up @@ -143,6 +144,8 @@ def show_install_usage():
print(" sbase get edgedriver")
print(" sbase get chromedriver 114")
print(" sbase get chromedriver 114.0.5735.90")
print(" sbase get chromedriver stable")
print(" sbase get chromedriver beta")
print(" sbase get chromedriver -p")
print(" Output:")
print(" Downloads the webdriver to seleniumbase/drivers/")
Expand Down Expand Up @@ -984,6 +987,7 @@ def main():
proxy_helper.validate_proxy_string(proxy_string)
break
try:
settings.HIDE_DRIVER_DOWNLOADS = False
sb_install.main()
except Exception as e:
invalid_run_cmd = constants.Warnings.INVALID_RUN_COMMAND
Expand Down
Loading

0 comments on commit ea02531

Please sign in to comment.