Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the lang arg via the cdp_driver isn't taking effect #3569

Closed
mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Closed

Setting the lang arg via the cdp_driver isn't taking effect #3569

mdmintz opened this issue Feb 26, 2025 · 1 comment · Fixed by #3573
Assignees
@mdmintz
Labels
bug Uh oh... Something needs to be fixed UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode

Comments

@mdmintz
Copy link
Member

mdmintz commented Feb 26, 2025

Setting the lang arg via the cdp_driver isn't taking effect

SeleniumBase/seleniumbase/undetected/cdp_driver/cdp_util.py

Line 235 in 5d732a4

lang: Optional[str] = None,

This is the pure CDP Mode equivalent of setting the locale / locale_code.
@mdmintz mdmintz added bug Uh oh... Something needs to be fixed UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode labels Feb 26, 2025
@mdmintz mdmintz self-assigned this Feb 26, 2025
@mdmintz mdmintz mentioned this issue Feb 26, 2025
Merged
@mdmintz
Copy link
Member Author

mdmintz commented Feb 26, 2025

This was resolved in 4.35.2 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.35.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmintz mdmintz

Labels
bug Uh oh... Something needs to be fixed UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CDP Mode: Patch 38 seleniumbase/SeleniumBase
1 participant
@mdmintz