Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

Sync upstream 4.19.1 #72

Merged
merged 6 commits into from
Mar 31, 2024
Merged

Sync upstream 4.19.1 #72

merged 6 commits into from
Mar 31, 2024

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

VietND96 and others added 6 commits March 29, 2024 03:59
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
…iumHQ#2176)

- Installing a chart containing selenium-grid chart as a dependency, values are nil: the block above produces empty output, looks like it performs no iterations
- Installing a chart containing selenium-grid chart as a dependency, values are "": correct output
* update: base Selenium 4.19.1
* test: add test for node docker (dynamic grid)

---------

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 merged commit 966c60f into trunk Mar 31, 2024
1 check passed
@VietND96 VietND96 deleted the 4.19.1 branch March 31, 2024 15:47
VietND96 added a commit that referenced this pull request Mar 31, 2024
Sync upstream 4.19.1

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants