Sessions stats calculation #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 9, 2015 19:52
This reverts commit acdbc06.
Respond to the client with the error message returned by the last hub tried, when unable to create new session on any hub. Instead of just responding with the default error message which does not help a lot.
| @@ -116,7 +117,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response) | |||
|
|
|||
| String target = route + request.getRequestURI(); | |||
| HttpResponse hubResponse = client.execute(post(target, message)); | |||
| JsonMessage hubMessage = JsonMessageFactory.from(hubResponse.getEntity().getContent()); | |||
| hubMessage = JsonMessageFactory.from(hubResponse.getEntity().getContent()); | |||
|
|
|||
| if (hubResponse.getStatusLine().getStatusCode() == SC_OK) { | |||
There was a problem hiding this comment.
Refactor this code to not nest more than 3 if/for/while/switch/try statements. 
|
SonarQube analysis reported 2 issues:
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all changes from #19 and provides the ability to implement custom implementations of StatsCounter with any data structure.