-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modification to monitor git submodules and depend on multi flavor and build assemble task #3
Conversation
…ll capture git submodule changes
…build configuration
Hey, thanks for the feedback and contribution. :) I'm all for running the Git commands on the project root directory. For your change to the In other words, your root subprojects {
apply plugin: 'com.selesse.git.changelog'
} If you do this, it should create a Thanks! |
the assemble need to be changed because you only add it to depends on "assemble", while my android project, I created a combination of product flavor and built variant. And i used your plugin with my versioning plugin and in the current project set up, i don't run "assemble", but run the variant instead. By the way, the change log generation part. When i tagged the latest commit then I got nothing. If i run your plugin before tagging the latest commit, then I got "Unreleased". What should come of out of course all commit message up to the last tagged commit |
I'd rather specifically hook into the Android tasks separately. I want users to enable the plugin for specific modules, but not be forced to use it for all modules. I'm trying to figure out what would make the most sense here. I've started work on an Android branch -- the logic for hooking into the different build variants can be found here. |
Oh. Now i see where you coming at. I do put your plugin in subproject build.gradle. Here are snippets of my build.gradle
What will happen in Android, Gradle will create
How currently I build this project is by invoking one assemble task at a time. |
OK, I think I understand now, thanks for clearing that up. What if, for Android plugins, I hooked into tasks that started with if (hasAndroidPlugin()) {
project.plugins.withType(getAndroidPlugin()) {
logger.info("Configuring Android plugin")
project.tasks.findAll { t -> t.name.startsWith('assemble') }.each {
it.dependsOn(task)
}
}
} Would that satisfy your use case? |
That what i did in my fork, and i published to jCenter for my own usage for now :) I'm not so familiar with how Gradle and groovy scripting, but i found that if i didn't call like these below.
|
OK, I'll look into it. Would you be OK with rebasing to only include the change to run the Git commands in the project root directory so I can merge that in? I'll create separate issues for the |
sure. i will clean up the code and usage as well. yesterday i just created what i requires to have :) |
You plugin is great, but i need more function for submodules.
This is my modification.