Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple features (watchdog disable, sd hot-plug) #186

Merged
82 commits merged into from
Feb 18, 2023

Conversation

tadeubas
Copy link
Contributor

@tadeubas tadeubas commented Feb 8, 2023

New Config to user disable watchdog to Live debug a device

Closes #184 - Added possibility to disable the Krux watchdog via config property WATCHDOG_DISABLE

match seedsigner/coldcard 99 D6 rolls
100th can be discarted as a full byte is used for checksum
"sensor" no longer needed in board.py
"orientation" also no longer needed
Add prompt to new words when loading seed
Seed QR simulator compatibility
QR grids
Standard prompt for printing
Pylint, black
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #186 (0b413bd) into develop (c19c03e) will increase coverage by 0.02%.
The diff coverage is 96.34%.

❗ Current head 0b413bd differs from pull request most recent head 386da71. Consider uploading reports for the commit 386da71 to get more accurate results

@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
+ Coverage    96.18%   96.21%   +0.02%     
===========================================
  Files           29       30       +1     
  Lines         2830     2876      +46     
===========================================
+ Hits          2722     2767      +45     
- Misses         108      109       +1     
Impacted Files Coverage Δ
src/krux/context.py 100.00% <ø> (ø)
src/krux/settings.py 98.66% <ø> (ø)
src/krux/printers/cnc.py 94.59% <77.77%> (-1.21%) ⬇️
src/krux/pages/login.py 89.57% <85.71%> (-0.09%) ⬇️
src/krux/pages/home.py 97.70% <100.00%> (+0.82%) ⬆️
src/krux/sd_card.py 100.00% <100.00%> (ø)
src/krux/translations.py 100.00% <100.00%> (ø)
src/krux/wdt.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tadeubas tadeubas changed the title Develop Config to disable watchdog #184 Feb 8, 2023
@tadeubas tadeubas changed the title Config to disable watchdog #184 New Config to user disable watchdog to Live debug a device Feb 8, 2023
@tadeubas tadeubas changed the title New Config to user disable watchdog to Live debug a device Multiple features Feb 13, 2023
@tadeubas
Copy link
Contributor Author

Working on #157 - Hot-plugging an SD card. PR related with this MaixPy change selfcustody/MaixPy#5

@tadeubas
Copy link
Contributor Author

Closes #157 - only 2 tests from .\tests\pages\test_home.py are broken, I tried to fix without success 😭

@tadeubas tadeubas changed the title Multiple features Multiple features (watchdog disable, sd hot-plug) Feb 14, 2023
@ghost
Copy link

ghost commented Feb 18, 2023

@tadeubas @odudex Since this is branched from odudex's work, I'm going to just merge this PR into develop and follow it up with my own changes

@ghost ghost merged commit 0dc4181 into selfcustody:develop Feb 18, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants