fix: copy cmake/ directory when cloning ros2_medkit#32
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure issue by preserving the cmake/ directory when selectively extracting ros2_medkit packages. The cmake directory contains ROS2MedkitCompat.cmake, which is required by gateway, serialization, and fault_manager packages during the colcon build process.
Changes:
- Added cmake directory extraction step to all three demo Dockerfiles
- Ensures ROS2MedkitCompat.cmake is available at workspace level before package builds
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| demos/turtlebot3_integration/Dockerfile | Adds cmake directory extraction after git clone, before package extraction |
| demos/sensor_diagnostics/Dockerfile | Adds cmake directory extraction after git clone, before package extraction |
| demos/moveit_pick_place/Dockerfile | Adds cmake directory extraction after git clone, before package extraction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Preserve ROS2MedkitCompat.cmake from the ros2_medkit clone before deleting it. Without this, colcon build fails because gateway, serialization, and fault_manager packages cannot resolve their ../../cmake/ROS2MedkitCompat.cmake include path. Mirrors the fix already applied to turtlebot3 and sensor_diagnostics.
set -e does not catch failures inside && lists, so a failed docker build would silently continue and print the success banner. Split build and up into separate steps with an explicit exit on build failure, tearing down any partial containers.
bburda
force-pushed
the
fix/missing-cmake
branch
from
3823008 to
2a80c0e
Compare
mfaferek93
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROS2MedkitCompat.cmake was not being preserved during the selective extraction of ros2_medkit packages, causing build failures in gateway, serialization, and fault_manager packages that depend on it.
closes #33