fix(faults): handle simulation time timestamps in fault display#28
Merged
fix(faults): handle simulation time timestamps in fault display#28
Conversation
When running with use_sim_time=true, fault timestamps are recorded in simulation time (seconds since sim start) instead of Unix epoch. This caused UI to display dates like "1/1/1970 00:02:28". Detect small timestamps (< year 2000) and substitute current time as a workaround until fault_manager is fixed to use wall clock time.
2cd6f70 to
bc47d0e
Compare
bburda
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
When running with use_sim_time=true, fault timestamps are recorded in simulation time (seconds since sim start) instead of Unix epoch. This caused UI to display dates like "1/1/1970 00:02:28".
Detect small timestamps (< year 2000) and substitute current time as a workaround until fault_manager is fixed to use wall clock time.
Issue
Link the related issue (required):
Type
Testing
How was this tested / how should reviewers verify it?
Checklist
npm run lint)npm run build)