Skip to content

Commit

Permalink
Remove -fpackage-trust
Browse files Browse the repository at this point in the history
It’s just too flaky.
  • Loading branch information
sellout committed Aug 26, 2024
1 parent 6ab91a7 commit fa1377b
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 157 deletions.
21 changes: 0 additions & 21 deletions containers/yaya-containers.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ common defaults
-- Warns even when `Unsafe` is explicit, not inferred. See
-- https://gitlab.haskell.org/ghc/ghc/-/issues/16689
-Wno-unsafe
-fpackage-trust
-trust base
if impl(ghc < 8.8.1)
ghc-options:
-- This used to warn even when `Safe` was explicit.
Expand All @@ -114,8 +112,6 @@ common defaults
-Wno-inferred-safe-imports
-- We support GHC versions without qualified-post.
-Wno-prepositive-qualified-module
-- `-trust` triggers this warning when applied to transitive dependencies.
-Wno-unused-packages
if impl(ghc >= 9.2.1)
ghc-options:
-- We support GHC versions without kind signatures.
Expand Down Expand Up @@ -163,23 +159,6 @@ library
build-depends:
containers ^>= {0.6.0, 0.7},
yaya ^>= {0.5.1, 0.6.0},
ghc-options:
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust profunctors
-trust semigroupoids
-trust stm
-trust text
-trust transformers-compat
exposed-modules:
Yaya.Containers.Pattern.IntMap
Yaya.Containers.Pattern.IntSet
Expand Down
29 changes: 0 additions & 29 deletions core/yaya.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ common defaults
-- Warns even when `Unsafe` is explicit, not inferred. See
-- https://gitlab.haskell.org/ghc/ghc/-/issues/16689
-Wno-unsafe
-fpackage-trust
-trust base
if impl(ghc < 8.8.1)
ghc-options:
-- This used to warn even when `Safe` was explicit.
Expand All @@ -120,8 +118,6 @@ common defaults
-Wno-inferred-safe-imports
-- We support GHC versions without qualified-post.
-Wno-prepositive-qualified-module
-- `-trust` triggers this warning when applied to transitive dependencies.
-Wno-unused-packages
if impl(ghc >= 9.2.1)
ghc-options:
-- We support GHC versions without kind signatures.
Expand Down Expand Up @@ -180,31 +176,6 @@ library
-- th-abstraction < 0.3 has different field names
th-abstraction ^>= {0.4.1, 0.5.0, 0.6.0, 0.7.0},
transformers ^>= {0.5.5, 0.6.1},
-- NB: foldable-classes-compat is a transitive dependency … depending on
-- which version of other dependencies (specifically,
-- indexed-traversable) we select. However, `-trust` only works for
-- packages in the dependency graph, so we make it explicit here for the
-- times that it doesn’t get included transitively.
foldable1-classes-compat ^>= {0.1},
ghc-options:
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust lens
-trust profunctors
-trust semigroupoids
-trust stm
-trust template-haskell
-trust text
-trust transformers-compat
exposed-modules:
Yaya.Applied
Yaya.Experimental.Foldable
Expand Down
37 changes: 0 additions & 37 deletions hedgehog/yaya-hedgehog.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ common defaults
-- Warns even when `Unsafe` is explicit, not inferred. See
-- https://gitlab.haskell.org/ghc/ghc/-/issues/16689
-Wno-unsafe
-fpackage-trust
-trust base
if impl(ghc < 8.8.1)
ghc-options:
-- This used to warn even when `Safe` was explicit.
Expand All @@ -117,8 +115,6 @@ common defaults
-Wno-inferred-safe-imports
-- We support GHC versions without qualified-post.
-Wno-prepositive-qualified-module
-- `-trust` triggers this warning when applied to transitive dependencies.
-Wno-unused-packages
if impl(ghc >= 9.2.1)
ghc-options:
-- We support GHC versions without kind signatures.
Expand Down Expand Up @@ -168,23 +164,6 @@ library
deriving-compat ^>= {0.5.9, 0.6},
hedgehog ^>= {1.0, 1.1, 1.2, 1.4},
yaya ^>= {0.5.1, 0.6.0},
ghc-options:
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust profunctors
-trust semigroupoids
-trust stm
-trust text
-trust transformers-compat
exposed-modules:
Yaya.Hedgehog
Yaya.Hedgehog.Expr
Expand Down Expand Up @@ -242,20 +221,4 @@ test-suite yaya
ghc-options:
-rtsopts
-threaded
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust profunctors
-trust semigroupoids
-trust stm
-trust text
-trust transformers-compat
-with-rtsopts=-N
29 changes: 0 additions & 29 deletions quickcheck/yaya-quickcheck.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ common defaults
-- Warns even when `Unsafe` is explicit, not inferred. See
-- https://gitlab.haskell.org/ghc/ghc/-/issues/16689
-Wno-unsafe
-fpackage-trust
-trust base
if impl(ghc < 8.8.1)
ghc-options:
-- This used to warn even when `Safe` was explicit.
Expand All @@ -117,8 +115,6 @@ common defaults
-Wno-inferred-safe-imports
-- We support GHC versions without qualified-post.
-Wno-prepositive-qualified-module
-- `-trust` triggers this warning when applied to transitive dependencies.
-Wno-unused-packages
if impl(ghc >= 9.2.1)
ghc-options:
-- We support GHC versions without kind signatures.
Expand Down Expand Up @@ -167,31 +163,6 @@ library
build-depends:
QuickCheck ^>= {2.10, 2.13.2, 2.14.2},
yaya ^>= {0.5.1, 0.6.0},
-- NB: splitmix is a transitive dependency … if we select QuickCheck >=
-- 2.13. However, `-trust` only works for packages in the dependency
-- graph, so we make it explicit here for the times that it doesn’t get
-- included transitively.
splitmix ^>= {0.0.1, 0.1.0},
ghc-options:
-trust QuickCheck
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust profunctors
-trust random
-trust semigroupoids
-trust splitmix
-trust stm
-trust text
-trust transformers-compat
exposed-modules:
Yaya.QuickCheck.Fold

Expand Down
41 changes: 0 additions & 41 deletions unsafe/yaya-unsafe.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ common defaults
-- Warns even when `Unsafe` is explicit, not inferred. See
-- https://gitlab.haskell.org/ghc/ghc/-/issues/16689
-Wno-unsafe
-fpackage-trust
-trust base
if impl(ghc < 8.8.1)
ghc-options:
-- This used to warn even when `Safe` was explicit.
Expand All @@ -122,8 +120,6 @@ common defaults
-Wno-inferred-safe-imports
-- We support GHC versions without qualified-post.
-Wno-prepositive-qualified-module
-- `-trust` triggers this warning when applied to transitive dependencies.
-Wno-unused-packages
if impl(ghc >= 9.2.1)
ghc-options:
-- We support GHC versions without kind signatures.
Expand Down Expand Up @@ -170,30 +166,11 @@ library
hs-source-dirs:
src
build-depends:
bifunctors ^>= {5.5.7, 5.6},
comonad ^>= 5.0.7,
free ^>= {5.1.5, 5.2},
-- `Control.Lens` in lens < 5 is `Unsafe`
lens ^>= {5, 5.1, 5.2, 5.3},
yaya ^>= {0.5.1, 0.6.0},
ghc-options:
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust lens
-trust profunctors
-trust semigroupoids
-trust stm
-trust text
-trust transformers-compat
exposed-modules:
Yaya.Unsafe.Applied
Yaya.Unsafe.Fold
Expand Down Expand Up @@ -250,22 +227,4 @@ test-suite yaya-unsafe
-fno-omit-yields
-rtsopts
-threaded
-trust adjunctions
-trust array
-trust base-orphans
-trust binary
-trust bytestring
-trust containers
-trust distributive
-trust exceptions
-trust foldable1-classes-compat
-trust ghc-prim
-trust hashable
-trust lens
-trust profunctors
-trust semigroupoids
-trust stm
-trust template-haskell
-trust text
-trust transformers-compat
-with-rtsopts=-N

0 comments on commit fa1377b

Please sign in to comment.