Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit profile page #136

Merged
merged 5 commits into from
Sep 30, 2023
Merged

Edit profile page #136

merged 5 commits into from
Sep 30, 2023

Conversation

pedrosilva17
Copy link
Contributor

Closes #108
Currently similar to the default edit profile page from Laravel, now in a different route. The sentences in here need to be added to #75 (I can do that after this is merged, if you want @Naapperas)

image

image

image

@pedrosilva17 pedrosilva17 force-pushed the feature/edit-profile-page branch 2 times, most recently from 2575e34 to 9b00af4 Compare September 27, 2023 14:16
Copy link
Contributor

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be careful with the amount of divs you use. Ask @ttoino if you have any doubts regarding that matter.

resources/js/Pages/Profile/Edit.vue Outdated Show resolved Hide resolved
@pedrosilva17 pedrosilva17 changed the title Edit profile page structure, based on Laravel's Edit profile page Sep 30, 2023
@pedrosilva17 pedrosilva17 force-pushed the feature/edit-profile-page branch 2 times, most recently from 7ae820c to be0ee0c Compare September 30, 2023 08:32
Naapperas
Naapperas previously approved these changes Sep 30, 2023
@Naapperas
Copy link
Contributor

@pedrosilva17 one thing I noticed: perhaps we could make the font of this page's text bold, or at least make it stand out more.

@Naapperas Naapperas force-pushed the feature/edit-profile-page branch from c1f17c8 to 81f9dc7 Compare September 30, 2023 19:22
@Naapperas Naapperas merged commit f56a055 into main Sep 30, 2023
@Naapperas Naapperas deleted the feature/edit-profile-page branch September 30, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page for users to edit their info
3 participants