feat: commit files from assets even if in they are in .gitignore
#56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `.gitignore` file is now ignored when adding files to the release commit Each files matching a glob in `assets` will now be included in the release commit. The `assets` option has now to be configured to match exactly the the files that have to be commited, independently of the `.gitignore` file.
gr2m
approved these changes
Jun 27, 2018
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
May 12, 2025
Turns out ignoring `.gitignore` while adding files to the release commit is a feature not a bug so specify the list of files to add. Refs: semantic-release/git#56 We can probably revert if semantic-release/git#527 ever gets merged.
rvagg
pushed a commit
to ipld/js-dag-cbor
that referenced
this pull request
May 20, 2025
Turns out ignoring `.gitignore` while adding files to the release commit is a feature not a bug so specify the list of files to add. Refs: semantic-release/git#56 We can probably revert if semantic-release/git#527 ever gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55
BREAKING CHANGE: the
.gitignorefile is now ignored when adding files to the release commitEach files matching a glob in
assetswill now be included in the release commit. Theassetsoption has now to be configured to match exactly the the files that have to be commited, independently of the.gitignorefile.