-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: exclude PRs with specific labels from commenting #361
Comments
I don't even think labels are needed; it was very surprising that this was posted for commits which were not part of the release spec. Given that the plugin is given information on which commits are considered 'worth making a release' for, maybe there should be an option for 'only include version changing commits'? <I can start a new issue for this but added it here because the reasoning for wanting it is the same; exclude chore/docs and other PRs which may not go to users> |
I looked through the plugin development guide and it seems a filtered list of commits isn't passed through context so a It seems like the expectation is all filtering steps (analyze, generate notes) are expected to just use the same filtering logic independently. github could do that too but it may be too ancillary compared to its core function so maybe a label based mechanism would be more palatable to the maintainers? |
This is now possible in configuration with the successCommentCondition: "<% return issue.label?.includes('specific-label-name') %>" The above config sets you up for only comment/label issues and pull-requests with specific label, if you intend it to be PRs alone then you want to state for PRs alone like so.... successCommentCondition: "<% return issue.pull_request && issue.label?.includes('specific-label-name') %>" |
This is somewhat similar to #359.
There may be some PRs that don't need release comments, such as dependency management and chores. It'd be nice to exclude them by labels like:
The text was updated successfully, but these errors were encountered: