fix: publish a release when env.GITHUB_URL is set to https://github.com #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
268/env-github-api-url
branch
from
27d615a to
9830d68
Compare
gr2m
force-pushed
the
268/env-github-api-url
branch
from
9830d68 to
230983b
Compare
gr2m
commented
May 14, 2020
| * @param {String} [githubApiPathPrefix=env.GH_PREFIX || env.GITHUB_PREFIX || ''] The GitHub Enterprise API prefix. | ||
| * @return {Object} A `nock` object ready to respond to a github authentication request. | ||
| */ | ||
| function authenticate( | ||
| env = {}, | ||
| { | ||
| githubToken = env.GH_TOKEN || env.GITHUB_TOKEN || 'GH_TOKEN', | ||
| githubUrl = env.GH_URL || env.GITHUB_URL || 'https://api.github.com', | ||
| githubUrl = env.GITHUB_API_URL || env.GH_URL || env.GITHUB_URL || 'https://api.github.com', |
There was a problem hiding this comment.
it feels a bit odd that we replicate the implementation of env variable parsing here. We basically test our test helper now, instead of the actual implementation. But I don't have a better idea
|
🎉 This PR is included in version 7.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 17, 2020
codfish
added a commit
to codfish/semantic-release-action
that referenced
this pull request
May 23, 2020
virgoone
pushed a commit
to virgoone/semantic-release-action
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #268, ping @ericsciple