Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max_node_limit_exceeded error when fetching associatedPRs #912

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

babblebey
Copy link
Member

@babblebey babblebey commented Sep 3, 2024

The PR addressed the issue where we our graphql query that fetches associatedPRs hits a case where it requests for 1million plus nodes exceeding the GitHub Node Limits size. It does this by simply reducing the number of labels requested per associatedPRs reducing the maximum possible requests to 410,000 just right below 500,000 which is GitHub's maximum Node Limit size.

Changes Made:

  • Updated the first value in the baseField constant from 100 to 40 for all graphql request that consumes it 😁

Related Issues

Fixes #911

@babblebey babblebey marked this pull request as ready for review September 3, 2024 18:00
@babblebey babblebey requested a review from travi September 3, 2024 18:19
@babblebey babblebey merged commit bb806af into master Sep 3, 2024
6 checks passed
@babblebey babblebey deleted the fix/max-node-limit branch September 3, 2024 19:25
Copy link

github-actions bot commented Sep 3, 2024

🎉 This issue has been resolved in version 10.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX_NODE_LIMIT_EXCEEDED
2 participants