Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing "PullRequest".canBeRebased field on GHES graphql api #913

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: missing "PullRequest".canBeRebased field on GHES graphql api #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1dd13
fix: remove `canBeRebased` from graphql request
babblebey Sep 3, 2024
58992b3
test: modify tests
babblebey Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/success.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,6 @@ function buildAssociatedPRsQuery(shas) {
nodes {
${baseFields}
mergeable
canBeRebased
changedFiles
mergedAt
isDraft
Expand Down Expand Up @@ -483,7 +482,6 @@ const loadSingleCommitAssociatedPRs = `#graphql
nodes {
${baseFields}
mergeable
canBeRebased
changedFiles
mergedAt
isDraft
Expand Down Expand Up @@ -557,7 +555,6 @@ function buildIssuesOrPRsFromResponseNode(responseNodes, type = "ISSUE") {
const prProps = {
pull_request: true,
mergeable: node.mergeable,
rebaseable: node.canBeRebased,
changed_files: node.changedFiles,
commits: node.commits?.totalCount,
merged_at: node.mergedAt,
Expand Down
4 changes: 0 additions & 4 deletions test/success.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3149,7 +3149,6 @@ test('Add comment and label to found issues/associatedPR using the "successComme
milestone: null,
locked: false,
mergeable: "UNKNOWN",
canBeRebased: false,
changedFiles: 1,
mergedAt: "2024-06-30T14:44:05Z",
isDraft: false,
Expand Down Expand Up @@ -3198,7 +3197,6 @@ test('Add comment and label to found issues/associatedPR using the "successComme
milestone: null,
locked: false,
mergeable: "UNKNOWN",
canBeRebased: false,
changedFiles: 1,
mergedAt: "2024-06-30T14:44:05Z",
isDraft: false,
Expand Down Expand Up @@ -3385,7 +3383,6 @@ test('Does not comment/label associatedPR and relatedIssues created by "Bots"',
milestone: null,
locked: false,
mergeable: "UNKNOWN",
canBeRebased: false,
changedFiles: 1,
mergedAt: "2024-07-13T09:58:50Z",
isDraft: false,
Expand Down Expand Up @@ -3432,7 +3429,6 @@ test('Does not comment/label associatedPR and relatedIssues created by "Bots"',
milestone: null,
locked: false,
mergeable: "UNKNOWN",
canBeRebased: false,
changedFiles: 1,
mergedAt: "2024-07-13T09:58:50Z",
isDraft: false,
Expand Down