Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file labels in GitLab releases, to ensure they're unique. #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: file labels in GitLab releases, to ensure they're unique. #267

wants to merge 1 commit into from

Commits on Sep 24, 2021

  1. fix: file labels in GitLab releases, to ensure they're unique. 

    Previously GitLab lables were just the basename for files uploaded as
part of the release. This is problematic because GitLab doesn't allow
conflicting labels -- a condition that could be caused by uploading a
release with two files by the same name in different directories. This
would generate a 409 Conflict error.

This changes the labels for files uploaded as part of a release to the
name relative to pkgRoot, or the package.

A project may look like this

  pkg
  pkg \ foo \ baz
  pkg \ bar \ baz

This would previously result in two conflicting labels of 'baz'. Now you
would have {"foo/baz", "bar/baz"} with no conflict.

GitHub issues: semantic-release#265, semantic-release#158
    @EvanCarroll
    EvanCarroll committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    04f20f2 View commit details
    Browse the repository at this point in the history