Skip to content

Feat(Comment): Add new parameters commentSuccessTo #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Feat(Comment): Add new parameters commentSuccessTo #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/resolve-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export default (
assets: assets ? castArray(assets) : assets,
milestones: milestones ? castArray(milestones) : milestones,
successComment,
commentSuccessTo: isNil(commentSuccessTo) ? "merge-request,issue" : commentSuccessTo,
proxy: getProxyConfiguration(defaultedGitlabUrl, HTTP_PROXY, HTTPS_PROXY, NO_PROXY),
failTitle: isNil(failTitle) ? "The automated release is failing 🚨" : failTitle,
failComment,
Expand Down
20 changes: 13 additions & 7 deletions lib/success.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default async (pluginConfig, context) => {
commits,
releases,
} = context;
const { gitlabToken, gitlabUrl, gitlabApiUrl, successComment, proxy } = resolveConfig(pluginConfig, context);
const { gitlabToken, gitlabUrl, gitlabApiUrl, successComment, proxy, commentSuccessTo } = resolveConfig(pluginConfig, context);
const repoId = getRepoId(context, gitlabUrl, repositoryUrl);
const encodedRepoId = encodeURIComponent(repoId);
const apiOptions = { headers: { "PRIVATE-TOKEN": gitlabToken } };
Expand Down Expand Up @@ -90,12 +90,18 @@ export default async (pluginConfig, context) => {
(await Promise.all(commits.map((commit) => getRelatedMergeRequests(commit.hash)))).flat(),
isEqual
);
const relatedIssues = uniqWith(
(await Promise.all(relatedMergeRequests.map((mergeRequest) => getRelatedIssues(mergeRequest)))).flat(),
isEqual
);
await Promise.all(relatedIssues.map((issues) => postCommentToIssue(issues)));
await Promise.all(relatedMergeRequests.map((mergeRequest) => postCommentToMergeRequest(mergeRequest)));

if(commentSuccessTo.trim().includes("merge-request")) {
await Promise.all(relatedMergeRequests.map((mergeRequest) => postCommentToMergeRequest(mergeRequest)));
}

if(commentSuccessTo.trim().includes("issue")) {
const relatedIssues = uniqWith(
(await Promise.all(relatedMergeRequests.map((mergeRequest) => getRelatedIssues(mergeRequest)))).flat(),
isEqual
);
await Promise.all(relatedIssues.map((issues) => postCommentToIssue(issues)));
}
} catch (error) {
logger.error("An error occurred while posting comments to related issues and merge requests:\n%O", error);
throw error;
Expand Down