Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli from the supported networks #352

Closed
vplasencia opened this issue Sep 1, 2023 · 5 comments · Fixed by #569
Closed

Remove Goerli from the supported networks #352

vplasencia opened this issue Sep 1, 2023 · 5 comments · Fixed by #569
Assignees
Labels
devops 🔧 Operations management and dev tools documentation 📖 Improvements or additions to documentation

Comments

@vplasencia
Copy link
Member

vplasencia commented Sep 1, 2023

Goerli is deprecated and will be replaced by Holesovice.

Goerli needs to be removed from the following packages (semaphore repository):

And from the following repositories:

However, it makes sense to start working on this issue before releasing Semaphore v4, and in the meantime inform people that Goerli will not be supported anymore soon.

For now a solution can be to add an asterisk to Goerli, Optimism Goerli and Arbitrum Goerli on the website, add a note like The Goerli testnet is deprecated and link the following websites for more information:

@vplasencia vplasencia converted this from a draft issue Sep 1, 2023
@vplasencia vplasencia added documentation 📖 Improvements or additions to documentation devops 🔧 Operations management and dev tools labels Sep 1, 2023
@sumitvekariya
Copy link

Hey, I would like to contribute to this one,

only goerli should be remove from the supported networks? or Arbitrum Goerli & Optimism Goerli should also be removed?

@cedoor
Copy link
Member

cedoor commented Sep 6, 2023

only goerli should be remove from the supported networks? or Arbitrum Goerli & Optimism Goerli should also be removed?

Hey @sumitvekariya, only Goerli for now, as Arbitrum and Optimism are still migrating. I've added more info to the description. But the idea is to start working on this issue in Semaphore v4, and inform people that it is going to be deprecated soon in the doc in the meantime.

@sumitvekariya
Copy link

only goerli should be remove from the supported networks? or Arbitrum Goerli & Optimism Goerli should also be removed?

Hey @sumitvekariya, only Goerli for now, as Arbitrum and Optimism are still migrating. I've added more info to the description. But the idea is to start working on this issue in Semaphore v4, and inform people that it is going to be deprecated soon in the doc in the meantime.

Thanks for sharing all the details, I have created PR for adding warning and asterisk for the goerli networks in the meantime.

semaphore-protocol/website#102

@sumitvekariya
Copy link

@cedoor Nothing more needs to do at this moment right? or I shall move forward with removing goerli from the packages mentioned by you?

@cedoor
Copy link
Member

cedoor commented Sep 8, 2023

@cedoor Nothing more needs to do at this moment right? or I shall move forward with removing goerli from the packages mentioned by you?

It's ok for now 👍🏽 Thank you for your PR 🙏🏽

@aguzmant103 aguzmant103 added the good first issue Good for newcomers label Jan 3, 2024
@cedoor cedoor moved this from ♻️ Grooming to 🗒 Tasks in Semaphore Board Jan 10, 2024
@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Jan 10, 2024
@cedoor cedoor self-assigned this Jan 10, 2024
@cedoor cedoor moved this from 🏗 In Progress to 🗒 Tasks in Semaphore Board Jan 11, 2024
@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Jan 11, 2024
@cedoor cedoor removed the good first issue Good for newcomers label Jan 11, 2024
@cedoor cedoor moved this from 🏗 In Progress to 🗒 Tasks in Semaphore Board Jan 12, 2024
@cedoor cedoor moved this from 🗒 Tasks to 🏗 In Progress in Semaphore Board Jan 17, 2024
@cedoor cedoor moved this from 🏗 In Progress to 👀 In review in Semaphore Board Jan 17, 2024
cedoor added a commit that referenced this issue Jan 17, 2024
This was referenced Jan 17, 2024
@cedoor cedoor linked a pull request Jan 19, 2024 that will close this issue
2 tasks
@cedoor cedoor closed this as completed Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✔️ Done in Semaphore Board Jan 23, 2024
cedoor added a commit that referenced this issue Feb 10, 2024
cedoor added a commit that referenced this issue Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops 🔧 Operations management and dev tools documentation 📖 Improvements or additions to documentation
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

6 participants
@cedoor @sumitvekariya @vplasencia @aguzmant103 and others