Skip to content

Add defensive checks in getDeployedContract for missing data #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add defensive checks in getDeployedContract for missing data #1040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/utils/src/networks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,25 @@ export function getDeployedContract(supportedNetwork: SupportedNetwork) {
throw new Error(`Semaphore has not been deployed on '${supportedNetwork}' yet`)
}

const deployedContract = deployedContracts.find(({ network }) => network === supportedNetwork)
const networkDeployedContracts = deployedContracts.find(({ network }) => network === supportedNetwork)

return deployedContract!.contracts.find(({ name }) => name === "Semaphore") as {
if (!networkDeployedContracts) {
throw new Error(
`No deployed contracts found for network '${supportedNetwork}'. ` +
"Please ensure 'deployed-contracts.json' contains an entry for this network."
)
}

const semaphoreContract = networkDeployedContracts.contracts.find(({ name }) => name === "Semaphore")

if (!semaphoreContract) {
throw new Error(
`Contract 'Semaphore' not found in deployed contracts for network '${supportedNetwork}'. ` +
"Make sure deployments include 'Semaphore' for this network."
)
}

return semaphoreContract as {
name: string
address: string
startBlock: number
Expand Down