feat: remove prepublish script when creating template with Semaphore CLI

[0xshikhar]

feat: to remove the prepublish script from the scripts object of the package.json file of every cli template when the template is downloaded using the Semaphore CLI.

Related Issue(s)

Closes Issue#591

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have run yarn format and yarn lint without getting any errors
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[vplasencia]

Hey @0xshikhar it looks great! Thank you. Would you mind moving the new removePrePublishScript function to a new file called removePrePublishScript.ts? Similar to the getGroupIds.ts file.

Then the function will be something like export default function removePrePublishScript(...

[0xshikhar]

Hey @vplasencia, just created a separate file for removePrePublishScript function to a new file called removePrePublishScript.ts. Thanks for your guidance.

[vplasencia]

Hey @0xshikhar! Great! Thank you!

Since the updatedPackageJsonContent variable has the correct content, maybe it's better to use it directly to list the available scripts in line 121 instead of reading from the package.json file again. Then that line would be:

const { scripts } = JSON.parse(updatedPackageJsonContent)

instead of:

const { scripts } = JSON.parse(readFileSync(`${currentDirectory}/${projectDirectory}/package.json`, "utf8"))

What do you think?

[0xshikhar]

Hey @vplasencia, yes I also think that will be better - not to call the function again. Just updated the PR. Thanks !

[vplasencia]

Great work @0xshikhar! Thank you very much! 🙏

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.